[openssl-dev] Seeking feedback on some #ifdef changes

Roumen Petrov openssl at roumenpetrov.info
Sun Feb 8 12:54:26 UTC 2015


Hi Rich,

Salz, Rich wrote:
> Looking at just OPENSSL_NO_xxx, we have over 100 openssl #ifdef options and we are considering removing nearly a third of them.  Please reply soon if the following plan would cause problems. This will happen only in master, for post-1.0.2.
> We will remove the following options.  You could argue that the OPENSSL_NO_SHAxxx options be treated as crypto, but OpenSSL does not compile without SHA and SHA1 defined, and we have no interest in spending the time to fix it. So for consistency, we will remove all of them.

What about a) OPENSSL_NO_SSL2 and b) OPENSSL_NO_SSL3 and 
OPENSSL_NO_SSL3_METHOD ?
It seems to me master branch does not define #ifdef for those options in 
opensslconf.h .

Change log point that ssl v2 is removed. It is expected opensslconf.h to 
define unconditionally OPENSSL_NO_SSL2.

Please review ssl3. It seems to me b) is error in script.

>          [SNIP]
>          OPENSSL_NO_STORE
Also removing the code?


Regards,
Roumen Petrov



More information about the openssl-dev mailing list