[openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)

[Rainer Jung]

Am 11.02.2015 um 20:30 schrieb Andy Polyakov:
> The branch master has been updated
>         via  dda8199922f9d52087d2c41b22a61eb4f9671385 (commit)
>         via  c79e17731f462d6d42b917027a7085c0f59a2214 (commit)
>        from  b7c9187b32a14b5b4a850161aed5c044d2130d5a (commit)
>
>
> - Log -----------------------------------------------------------------
> commit dda8199922f9d52087d2c41b22a61eb4f9671385
> Author: Andy Polyakov <appro at openssl.org>
> Date:   Wed Feb 11 20:30:13 2015 +0100
>
>      Add Camellia CTR mode.
>
>      Reviewed-by: Rich Salz <rsalz at openssl.org>
>

...

> -----------------------------------------------------------------------
>
> Summary of changes:
>   crypto/evp/c_allc.c        |    3 ++
>   crypto/evp/e_camellia.c    |    9 ++---
>   crypto/evp/evptests.txt    |   64 ++++++++++++++++++++++++++++++++++
>   crypto/objects/obj_dat.h   |   82 +++++++++++++++++++++++++++++++++++++++++---
>   crypto/objects/obj_mac.h   |   60 ++++++++++++++++++++++++++++++++
>   crypto/objects/obj_mac.num |   12 +++++++
>   crypto/objects/objects.txt |   12 +++++++
>   7 files changed, 231 insertions(+), 11 deletions(-)
>
> diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c
> index 174a419..7ae36d7 100644
> --- a/crypto/evp/c_allc.c
> +++ b/crypto/evp/c_allc.c
> @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void)
>       EVP_add_cipher(EVP_camellia_256_ofb());
>       EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256");
>       EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256");
> +    EVP_add_cipher(EVP_camellia_128_ctr());
> +    EVP_add_cipher(EVP_camellia_192_ctr());
> +    EVP_add_cipher(EVP_camellia_256_ctr());
>   #endif
>   }

We get build warnings and crashes during run in EVP_add_cipher(). It 
seems EVP_camellia_128_ctr(), EVP_camellia_192_ctr() and 
EVP_camellia_256_ctr() are missing from crypto/evp/evp.h:

c_allc.c:248:5: warning: implicit declaration of function 
"EVP_camellia_128_ctr" [-Wimplicit-function-declaration]
      EVP_add_cipher(EVP_camellia_128_ctr());
etc.

Thanks,

Rainer