[openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)

[Andy Polyakov]

On 02/12/15 12:49, Rainer Jung wrote:
> Am 12.02.2015 um 12:00 schrieb Andy Polyakov:
>>>> diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c
>>>> index 174a419..7ae36d7 100644
>>>> --- a/crypto/evp/c_allc.c
>>>> +++ b/crypto/evp/c_allc.c
>>>> @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void)
>>>>        EVP_add_cipher(EVP_camellia_256_ofb());
>>>>        EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256");
>>>>        EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256");
>>>> +    EVP_add_cipher(EVP_camellia_128_ctr());
>>>> +    EVP_add_cipher(EVP_camellia_192_ctr());
>>>> +    EVP_add_cipher(EVP_camellia_256_ctr());
>>>>    #endif
>>>>    }
>>>
>>> We get build warnings and crashes during run in EVP_add_cipher().
>>
>> Thanks. I'm on it. Out of curiosity, with which config do you get
>> crashes? I don't mean that this doesn't need fixing, I only want to have
>> a reference.
> 
> Thanks to you.
> 
> The crash occurred while using it during a CI build for Tomcat plus
> Tomcat native connector (tcnative) which in turn uses OpenSSL.

Question was rather about OS. The question I seek answer to is how did
it evade the usual test and/or what is so special about your environment.

> OpenSSL was build with "config --prefix=... shared enable-deprecated".
> 
> I don't have a full stack available. The Java HS-Error file says:
> 
>     [junit] #
>     [junit] # A fatal error has been detected by the Java Runtime
> Environment:
>     [junit] #
>     [junit] #  SIGSEGV (0xb) at pc=0x00007fb882f66ef9, pid=32437,
> tid=140431064893184

Ah! Keyword is likely to be that it was shared build. I mean implicit
cast can slip through in non-shared case, because in such case code is
loaded in lower 2GB, while shared libraries tend to be mapped far above
4GB. Thanks.