[openssl-dev] [openssl.org #3646] Compile bug in 1.0.1k

[Goldsmith, Benjamin via RT]

Hello,

I've discovered a compile time bug.  The situation is:
OS: Windows 7-64 bit
Compiler: Visual C++ 11 (2012)
Build steps:
> perl Configure VC-WIN64A no-asm --prefix=deps_x64
<output snipped - no errors reported>
> ms\do_win64a
<output snipped - no errors reported>
> nmake -a -f ms\nt.mak
        cl /Fotmp32\cryptlib.obj  -Iinc32 -Itmp32 /MT /Ox -DOPENSSL_THREADS  -DD
SO_WIN32 -W3 -Gs0 -Gy -nologo -DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_
ENDIAN -DUNICODE -D_UNICODE -D_CRT_SECURE_NO_DEPRECATE -DOPENSSL_NO_RC5 -DOPENSS
L_NO_MD2 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_JPAKE -DOPENSSL_NO_DYNAMIC_ENGINE /Zl /Z
i /Fdtmp32/lib -c .\crypto\cryptlib.c
cryptlib.c
.\crypto\cryptlib.c(863) : warning C4267: 'function' : conversion from 'size_t'
to 'int', possible loss of data
        cl /Fotmp32\mem.obj  -Iinc32 -Itmp32 /MT /Ox -DOPENSSL_THREADS  -DDSO_WI
N32 -W3 -Gs0 -Gy -nologo -DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_ENDIA
N -DUNICODE -D_UNICODE -D_CRT_SECURE_NO_DEPRECATE -DOPENSSL_NO_RC5 -DOPENSSL_NO_
MD2 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_JPAKE -DOPENSSL_NO_DYNAMIC_ENGINE /Zl /Zi /Fd
tmp32/lib -c .\crypto\mem.c
mem.c
        cl /Fotmp32\mem_dbg.obj  -Iinc32 -Itmp32 /MT /Ox -DOPENSSL_THREADS  -DDS
O_WIN32 -W3 -Gs0 -Gy -nologo -DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_E
NDIAN -DUNICODE -D_UNICODE -D_CRT_SECURE_NO_DEPRECATE -DOPENSSL_NO_RC5 -DOPENSSL
_NO_MD2 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_JPAKE -DOPENSSL_NO_DYNAMIC_ENGINE /Zl /Zi
/Fdtmp32/lib -c .\crypto\mem_dbg.c
mem_dbg.c
        cl /Fotmp32\cversion.obj  -Iinc32 -Itmp32 /MT /Ox -DOPENSSL_THREADS  -DD
SO_WIN32 -W3 -Gs0 -Gy -nologo -DOPENSSL_SYSNAME_WIN32 -DWIN32_LEAN_AND_MEAN -DL_
ENDIAN -DUNICODE -D_UNICODE -D_CRT_SECURE_NO_DEPRECATE -DOPENSSL_NO_RC5 -DOPENSS
L_NO_MD2 -DOPENSSL_NO_KRB5 -DOPENSSL_NO_JPAKE -DOPENSSL_NO_DYNAMIC_ENGINE /Zl /Z
i /Fdtmp32/lib -DMK1MF_BUILD -DMK1MF_PLATFORM_VC_WIN64A -c .\crypto\cversion.c
cversion.c
.\crypto\cversion.c(80) : error C2065: 'cflags' : undeclared identifier
.\crypto\cversion.c(80) : warning C4047: 'return' : 'const char *' differs in le
vels of indirection from 'int'
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 11.0
\VC\BIN\x86_amd64\cl.EXE"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 11.0
\VC\BIN\nmake.EXE"' : return code '0x2'
Stop.

Inspecting crypto\cversion.c, it appears that there's a typo on line 80.  My speculation is that "cflags" should really be "CFLAGS".  When I make that change, the system compiles.

Best,
-Ben

Benjamin Goldsmith
Research Engineer
Nuance Communications, Inc.
1198 E. Arques Ave.
Sunnyvale, CA 94085
Direct: 408-992-6187
Mobile: 310-963-5790
Email: Benjamin.Goldsmith at nuance.com