[openssl-dev] On SSLv23_method() drop and TLS_method() introduction

[Steffen Nurpmeso]

Kurt Roeckx <kurt at roeckx.be> wrote:
 |On Tue, May 19, 2015 at 08:03:05PM +0200, Steffen Nurpmeso wrote:
 |> Steffen Nurpmeso <sdaoden at yandex.com> wrote:
 |>|Kurt Roeckx <kurt at roeckx.be> wrote:
 |>||I think that we should just provide the SSLv23_client_method define
 |>||without the need to enable something, and I guess I missed
 |>||something during the review in that case.
 |>|
 |>|Thanks for the clarification.
 |> 
 |> Ehm, one more nit: in order to be able to compile [master] i need
 |> this patch (tests like it fwiw):
 |
 |It builds fine for me.  Can you give the error where it fails to
 |build?

I never claimed the patch was correct, i still got

  c_zlib.c:113:5: warning: excess elements in struct initializer
      NULL,
    ^~~~

But understandably i wanted to adjust for upcoming 1.1.0 changes
asap (you seem to encourage people using [master] for this purpose
if i recall correctly) and then there was (i say «Ciao!» here)

c_zlib.c:113:5: warning: excess elements in struct initializer
    NULL,
    ^~~~
/usr/include/stdio.h:84:14: note: expanded from macro 'NULL'
#define NULL __DARWIN_NULL
             ^~~~~~~~~~~~~
/usr/include/sys/_types.h:91:23: note: expanded from macro '__DARWIN_NULL'
#define __DARWIN_NULL ((void *)0)
                      ^~~~~~~~~~~
c_zlib.c:203:57: error: no member named 'ex_data' in 'struct comp_ctx_st'
    CRYPTO_new_ex_data(CRYPTO_EX_INDEX_COMP, ctx, &ctx->ex_data);
                                                   ~~~  ^
c_zlib.c:204:30: error: no member named 'ex_data' in 'struct comp_ctx_st'
    CRYPTO_set_ex_data(&ctx->ex_data, zlib_stateful_ex_idx, state);
                        ~~~  ^
c_zlib.c:214:55: error: no member named 'ex_data' in 'struct comp_ctx_st'
        (struct zlib_state *)CRYPTO_get_ex_data(&ctx->ex_data,
                                                 ~~~  ^
c_zlib.c:219:58: error: no member named 'ex_data' in 'struct comp_ctx_st'
    CRYPTO_free_ex_data(CRYPTO_EX_INDEX_COMP, ctx, &ctx->ex_data);
                                                    ~~~  ^
c_zlib.c:228:55: error: no member named 'ex_data' in 'struct comp_ctx_st'
        (struct zlib_state *)CRYPTO_get_ex_data(&ctx->ex_data,
                                                 ~~~  ^
c_zlib.c:257:55: error: no member named 'ex_data' in 'struct comp_ctx_st'
        (struct zlib_state *)CRYPTO_get_ex_data(&ctx->ex_data,
                                                 ~~~  ^
1 warning and 6 errors generated.
make[2]: *** [c_zlib.o] Error 1
make[1]: *** [subdirs] Error 1
make: *** [build_crypto] Error 1
?2[steffen at sherwood openssl.git]$ gl1

--steffen