[openssl-dev] [openssl.org #4144] patch: Use '__sun' instead of 'sun' for strict ISO conforming, compiler/options

Andy Polyakov via RT rt at openssl.org
Sun Nov 22 13:08:55 UTC 2015


>>> I'd like to propose the attached patch to 1.0.2d which avoids problems
>>> with strict ISO conforming compiler/options, which do not define 'sun' only
>>> '__sun' as usual... such as gcc/clang -std=c99
>>>
>>> This affects the build itself, but also any user of openssl/opensslconf.h
>>
>> I've commited only the part that applied to the master branch, but
>> fixed that in all the branches.  Please let me know if you need
>> other changes in the stable branches.
> 
> ... If support [for SunOS 4] is not
> disclaimed then correct approach would be to look at target system, not
> what gcc/clang do on Linux.

In other words I argue in favour of reverting suggested change in
1.0.1/2. Because I can't find evidence that __sun is defined on said
platform.




More information about the openssl-dev mailing list