[openssl-dev] Minor bug in custom TLS extensions

Bill Cox waywardgeek at google.com
Wed Sep 2 15:00:52 UTC 2015


On Wed, Sep 2, 2015 at 7:55 AM, Matt Caswell <matt at openssl.org> wrote:

>
>
> On 02/09/15 15:50, Bill Cox wrote:
> > As for the order issue, we parse headers before creating any, so I'll
> > just not add the header in the AddCallback if s->hit is set on the
> > server side.  This should behave well long term, I think.
>
> Except that in master (i.e. version 1.1.0) you will not be able to
> access s->hit. You should use SSL_cache_hit instead.
>

Yes, I already had that pointed out :)  Thanks, though!  You can't be too
careful in this code base.

Bill
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-dev/attachments/20150902/9045d923/attachment-0001.html>


More information about the openssl-dev mailing list