[openssl-dev] [openssl.org #4010] AutoReply: [PATCH] Fix #include order in rand.h for Windows

[Kim Gräsman via RT]

Ping?

- Kim

On Tue, Aug 18, 2015 at 4:16 PM, The default queue via RT
<rt at openssl.org> wrote:
>
> Greetings,
>
> This message has been automatically generated in response to the
> creation of a trouble ticket regarding:
>         "[PATCH] Fix #include order in rand.h for Windows",
> a summary of which appears below.
>
> There is no need to reply to this message right now.  Your ticket has been
> assigned an ID of [openssl.org #4010].
>
> Please include the string:
>
>          [openssl.org #4010]
>
> in the subject line of all future correspondence about this issue. To do so,
> you may reply to this message.
>
>                         Thank you,
>                         rt at openssl.org
>
> -------------------------------------------------------------------------
> Hi all,
>
> When using OpenSSL on Windows, we've seen compiler errors when we
> #include <openssl/engine.h> after <openssl/x509.h> and then attempting
> to use X509_NAME in our code.
>
> This is because engine.h pulls in rand.h, which in turn includes
> windows.h. The Windows headers introduce conflicting #defines for
> X509_NAME (among other names). Most of the OpenSSL headers counteract
> this by #undef-ing the conflicting names. However, rand.h includes
> windows.h *after* ossl_types.h, so Windows re-#defines the symbols and
> wins again.
>
> The attached patch switches include order around so that ossl_types.h
> is included after windows.h, and thereby fixing the namespace up
> again.
>
> I've built on Windows and Linux and everything still appears to work.
>
> Please let me know if this is applicable to mainline OpenSSL.
>
> Thanks,
> - Kim
>