[openssl-dev] requirements for tests in openssl 1.1.0 (openssl-SNAP-20160331)

[Richard Levitte]

In message <56FE9EEC.1020905 at hlrs.de> on Fri, 1 Apr 2016 18:16:44 +0200, Martin Hecht <hecht at hlrs.de> said:

hecht> On 04/01/2016 05:20 PM, Matt Caswell wrote:
hecht> >
hecht> > On 01/04/16 16:06, Martin Hecht wrote:
hecht> >> on SUSE Linux Enterprise Server 11 SP3, when running
hecht> >>
hecht> >> ./config && make test
hecht> >>
hecht> >> I get errors like:
hecht> >> Compilation failed in require at ../test/recipes/90-test_v3name.t line 3.
hecht> >> BEGIN failed--compilation aborted at ../test/recipes/90-test_v3name.t
hecht> >> line 3.
hecht> >> # Looks like your test died before it could output anything.
hecht> >> ../test/recipes/90-test_v3name............dubious                           
hecht> >>
hecht> >>         Test returned status 255 (wstat 65280, 0xff00)
hecht> >> FAILED--72 test scripts could be run, alas--no output ever seen
hecht> >> make: *** [test] Error 255
hecht> >>
hecht> >> runing the tests manually shows that the Test::More module is of an
hecht> >> older version than expected:
hecht> >> /tmp/tmp.COsNuvUJPw/openssl-SNAP-20160331> perl
hecht> >> test/recipes/90-test_v3name.t
hecht> >> Test::More version 0.96 required--this is only version 0.72 at
hecht> >> /tmp/tmp.COsNuvUJPw/openssl-SNAP-20160331/test/testlib/OpenSSL/Test.pm
hecht> >> line 6.
hecht> >>
hecht> >> Of course I could install that perl module locally in my $HOME to get
hecht> >> the test running.
hecht> >> But is this a hard requirement or could a lower version do the job as well?
hecht> >>
hecht> >> The same problem on Scientific Linux  release 6.7 (Carbon), a RHEL clone:
hecht> >> ../test/recipes/01-test_abort.t ........... Test::More version 0.96
hecht> >> required--this is only version 0.92 at ../test/testlib/OpenSSL/Test.pm
hecht> >> line 6.
hecht> >>
hecht> >> On Ubuntu 14.04.4 LTS all the tests ran through happily.
hecht> > Test::More version 0.96 or above is a requirement in order to run the tests.
hecht> >
hecht> > Please refer to README.PERL for more information on this requirement and
hecht> > how to install any missing modules.
hecht> >
hecht> > Matt
hecht> thanks Matt, I should have checked the README.PERL first.
hecht> 
hecht> after updating  Test::Simple, Test::Builder, Test::Builder::Module, and
hecht> Test::More all tests succeed.
hecht> 
hecht> The README.PERL sais that you have bundled Text::Template as a fallback.
hecht> What about adding the above ones in the required version as well?

There's a few differences:

1) Text::Template isn't a core perl module, so we can't reasonably
   expect it to be installed more or less everywhere.  Test::More and
   accompanying modules are core perl, so can be reasonably expected
   to be present, even though we know that an upgrade is needed on
   older systems.
2) Text::Template is use more or less everywhere, even in Configure,
   we have it for all templating.  Test::More is "only" used when
   testing and is therefore not as critical.
3) Text::Template is a very simple module, very easy to bundle.
   Test::More and all its accompanying modules is a bit more complex.

For all those reasons, we found it reasonable enough to bundle
Text::Template but not Test::More et al.  Bundling is something we'd
rather avoid if we can, and is strictly reserved for non-code modules,
at least for now.

Cheers,
Richard

-- 
Richard Levitte         levitte at openssl.org
OpenSSL Project         http://www.openssl.org/~levitte/