[openssl-dev] '-CIPHER_DEBUG' error on 'dh_dsa'

[Alessandro Ghedini]

On Sat, Jan 16, 2016 at 01:51:28pm +0100, Gisle Vanem wrote:
> Having '-DCIPHER_DEBUG' in the CFLAGS causes this error in
> MingW (gcc 5.1):
>   ssl/ssl_lib.c:2499:58: error: 'dh_dsa' undeclared (first use in this function)
>             dh_tmp, rsa_enc, rsa_sign, dsa_sign, dh_rsa, dh_dsa);
> 
> (+ a lot wore warnings). Time to retire/rewrite this 'CIPHER_DEBUG'
> part? Or patch ssl/ssl_lib.c:
> 
> --- a/ssl/ssl_lib.c 2016-01-16 06:28:59
> +++ b/ssl/ssl_lib.c 2016-01-16 13:40:51
> @@ -2495,8 +2495,8 @@
> 
>  #ifdef CIPHER_DEBUG
>      fprintf(stderr,
> -            "dht=%d re=%d rs=%d ds=%d dhr=%d dhd=%d\n",
> -            dh_tmp, rsa_enc, rsa_sign, dsa_sign, dh_rsa, dh_dsa);
> +            "dht=%d re=%d rs=%d ds=%d\n",
> +            dh_tmp, rsa_enc, rsa_sign, dsa_sign);
>  #endif

IMO it's better to just remove it. It's unlikely anyone is using it since the
build breaks. I opened a pull request (that includes another #if-related fix):

    https://github.com/openssl/openssl/pull/559

Cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://mta.openssl.org/pipermail/openssl-dev/attachments/20160116/b7d6884a/attachment.sig>