[openssl-dev] [openssl.org #4277] DSAPublicKey should use dsa_cb in 1.1.0

[David Benjamin via RT]

DSAPublicKey lost the dsa_cb in
https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=ea6b07b54c1f8fc2275a121cdda071e2df7bd6c1

This results in d2i_DSAPublicKey using crypto/asn1's default allocation
logic rather than calling into DSA_new. I believe it should
use ASN1_SEQUENCE_cb.

I've attached a tiny sample program. On my machine, when building against
master, the second reference count is 0 and then the second DSA_free
crashes.

Also, the comment in dsa_asn1.c and d2i_DSAPublicKey.pod both still refer
to write_params which no longer exists.

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dsa_public_key.c
Type: application/octet-stream
Size: 593 bytes
Desc: not available
URL: <http://mta.openssl.org/pipermail/openssl-dev/attachments/20160128/3aa2e398/attachment.obj>