[openssl-dev] [openssl.org #4629] OpenSSL Bug Report: -DSSL_DEBUG typo

[Jon Loeliger via RT]

Build:

Linux jdl-centos.netgate.com 3.10.0-327.22.2.el7.x86_64 #1 SMP Thu Jun 23 17:05:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

against commmit:

    commit d49cfa3bd57ffba060f08e4088441fa392c2f9a8
    Author: Steffen Nurpmeso <steffen at sdaoden.eu>
    Date:   Mon Jul 25 12:25:15 2016 +0200

	RT4627: Doc patch: fix constant names

	Reviewed-by: Matt Caswell <matt at openssl.org>
	Signed-off-by: Rich Salz <rsalz at openssl.org>


When I add -DSSL_DEBUG to the build, I take a compile error here:

gcc  -I. -Iinclude -DDSO_DLFCN -DHAVE_DLFCN_H -DNDEBUG -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPOLY1305_ASM -DOPENSSL_NO_BUF_FREELISTS -DOPENSSL_USE_DEPRECATED -DOPENSSLDIR=3D"\"/home/jdl/workspace/qat-rpms/driver/BUILD/openssl/.openssl/ssl\"" -DENGINESDIR=3D"\"/home/jdl/workspace/qat-rpms/driver/BUILD/openssl/.openssl/lib/engines-1.1\"" -Wall -O3 -pthread - -m64 -DL_ENDIAN  -Wa,--noexecstack  -MMD -MF apps/s_client.d.tmp -MTapps/s_client.o -c -o apps/s_client.o apps/s_client.c

In file included from /usr/include/bits/byteswap.h:35:0,
                 from /usr/include/endian.h:60,
                 from /usr/include/ctype.h:40,
                 from apps/s_client.c:37:
apps/s_client.c: In function 'print_stuff':
apps/s_client.c:2624:51: error: 'union BIO_sock_info_u' has no member
named 'adr'
                        ntohs(BIO_ADDR_rawport(info.adr)));

Looks like a simple s/adr/addr/ typo.


diff --git a/apps/s_client.c b/apps/s_client.c
index bc89c98..0488a27 100644
--- a/apps/s_client.c
+++ b/apps/s_client.c
@@ -2621,7 +2621,7 @@ static void print_stuff(BIO *bio, SSL *s, int full)
         if ((info.addr = BIO_ADDR_new()) != NULL
             && BIO_sock_info(sock, BIO_SOCK_INFO_ADDRESS, &info)) {
             BIO_printf(bio_c_out, "LOCAL PORT is %u\n",
-                       ntohs(BIO_ADDR_rawport(info.adr)));
+                       ntohs(BIO_ADDR_rawport(info.addr)));
         }
         BIO_ADDR_free(info.addr);
     }


HTH,
jdl


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4629
Please log in as guest with password guest if prompted