[openssl-dev] [openssl.org #4549] powerpc test problem: missing symbols

[Sebastian Andrzej Siewior via RT]

On 2016-05-30 21:28:06 [+0000], Andy Polyakov via RT wrote:
> For what it's worth I can't reproduce problem on Fedora or RedHat.

The test
|…
|# The following symbols are missing in libcrypto.so:
|#   _shadow_DES_check_key
|not ok 2 - check that there are no missing symbols in libcrypto.so
|…

So it is about DES_check_key which is the only variable using
OPENSSL_IMPLEMENT_GLOBAL (and I don't see it beeing used).

On x86-64 :
| $ nm -Pg crypto/des/set_key.o|grep _shadow_DES_check_key
| _shadow_DES_check_key B 0000000000000000 0000000000000004

and on powerpc I get:
| $ nm -Pg crypto/des/set_key.o|grep _shadow_DES_check_key
| _shadow_DES_check_key S 00000000 00000004

and this fixes it:

--- a/test/recipes/01-test_symbol_presence.t
+++ b/test/recipes/01-test_symbol_presence.t
@@ -57,7 +57,7 @@ foreach my $libname (@libnames) {
         note "Number of lines in \@def_lines before massaging: ", scalar @def_lines;
 
         # Massage the nm output to only contain defined symbols
-        @nm_lines = sort map { s| .*||; $_ } grep(m|.* [BCDT] .*|, @nm_lines);
+        @nm_lines = sort map { s| .*||; $_ } grep(m|.* [BCDST] .*|, @nm_lines);
 
         # Massage the mkdef.pl output to only contain global symbols
         # The output we got is in Unix .map format, which has a global

I make a proper pull req later…

Sebastian


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4549
Please log in as guest with password guest if prompted