[openssl-dev] [openssl.org #4526] bug: use of ExitProcess on Windows platforms, 1.0.2g

[Ty Baen-Price via RT]

Hi!

I just looked on GitHub and I see the reason you reverted the change is that TerminateProcess is asynchronous. 

That is technically true, but I think it's probably synchronous "enough" for your purposes, since a call to TerminateProcess suspends execution of all threads in the target process. This means it's really only asynchronous if you're calling TerminateProcess one some *other* process. If you're calling TerminateProcess on your own process, you'll never return from the TerminateProcess call.

Regards,
Ty


-----Original Message-----
From: Matt Caswell via RT [mailto:rt at openssl.org] 
Sent: Friday, 17 June 2016 4:44 AM
To: Ty Baen-Price <tbaen at wynyardgroup.com>
Cc: openssl-dev at openssl.org
Subject: [openssl.org #4526] bug: use of ExitProcess on Windows platforms, 1.0.2g

On Wed Jun 15 17:42:58 2016, rsalz wrote:
> OpenSSL_1_0_2-stable 75f9068 RT4526: Call TerminateProcess, not 
> ExitProcess master 9c1a9cc RT4526: Call TerminateProcess, not 
> ExitProcess
>
> Author: Rich Salz <rsalz at openssl.org>
> Date: Tue Jun 14 16:19:37 2016 -0400
>
> RT4526: Call TerminateProcess, not ExitProcess
>
> Reviewed-by: Richard Levitte <levitte at openssl.org>

I just reverted this commit. We need to take another look at this, so reopening this ticket.

Matt

--
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4526
Please log in as guest with password guest if prompted


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4526
Please log in as guest with password guest if prompted