[openssl-dev] [openssl.org #4561] BUG: openssl-1.0.2h, evp_enc.c, non-portable bitwise operation

Matt Caswell via RT rt at openssl.org
Mon Jun 20 07:31:39 UTC 2016


On Mon Jun 13 09:37:59 2016, loic.etienne at qnective.com wrote:
> My claim about portability issues was wrong (sorry): The C-standard
> ensures that positive values are handled in the two's complement
> system, indeed.
>
> However, inl % block_size == inl & (block_size-1) is true if and only
> if block_size is a power of two, which happens to be true under the
> current implementation, but may change in the future.

I think if that assumption is probably in multiple places in the code. I don't
think this is worth fixing at this stage. Closing this ticket.

Matt

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4561
Please log in as guest with password guest if prompted



More information about the openssl-dev mailing list