[openssl-dev] [openssl.org #4245] OpenSSL-1.1-pre2 e_oss.h and inline conflicts

Richard Levitte via RT rt at openssl.org
Tue May 10 13:24:01 UTC 2016


Checking if inline is defined and using that definition is the right thing to
do. To check for ossl_inline would be absurd, as the header file guard
(HEADER_E_OS2_H) already does that job.

Perhaps the commit f820b79248140419c1c2ced9873aa1d78b665a76 fixed the issue?

Closing this ticket for now.

On Fri Jan 15 19:45:42 2016, rsalz at akamai.com wrote:
> e_os.2 line 327::
>
> # if !defined(inline) && !defined(__cplusplus)
>
> Should this be:
>
> # if !defined(ossl_inline) && !defined(__cplusplus)
>
> The purpose of this section is to end up with a good definition for
> ossl_inline
>
> If some preceding header file (and I have run across this) does a
> #define inline
>
> The e_os2.h will not change the ossl_inline and the safestack.h and
> other header files will prodice pages of errors.


--
Richard Levitte
levitte at openssl.org

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4245
Please log in as guest with password guest if prompted



More information about the openssl-dev mailing list