[openssl-dev] Syncing OpenSSL and BoringSSL mont ASM code

Brian Smith brian at briansmith.org
Thu May 26 01:12:01 UTC 2016


1. Please see
https://boringssl.googlesource.com/boringssl/+/75b833cc819a9d189adb0fdd56327bee600ff9e9
.

I think it would be good for OpenSSL to work with Google to integrate this
patch.

2. Is the `__chkstk` code that was added [1] to `bn_mul_mont` really
necessary? I noticed that when BoringSSL integrated the patch to fix the
constant-timedness issues in bn_mul_mont, it omitted the __chkstk stuff.
Even after reading the code and the comments, it still isn't clear to me
how/why it matters.

[1]
https://github.com/openssl/openssl/commit/adc4f1fc25b2cac90076f1e1695b05b7aeeae501

Thanks,
Brian
-- 
https://briansmith.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-dev/attachments/20160525/857f9aa5/attachment.html>


More information about the openssl-dev mailing list