[openssl-project] Style guide update -- summary so far

Paul Dale paul.dale at oracle.com
Mon Feb 5 20:59:25 UTC 2018


> Arguments inside macro expansions should be parenthesized.
>                 #define foo(a, b)  ((a) + (b))

Except when token concatenating a ## b and stringifying # a.

As an aside, should there be spaces on either size of the ## concatenator?  The current code mostly doesn't -- which means it sometimes does.  My feeling is use whichever is clearer but we might want to codify this as yes, no or submitter decides.

Likewise, should there be a space after the # stringifier?  Existing code doesn't, apparently without exception.  I'm pressed to think of a case where having a space increases clarity but I'm sure some exist.


Pauli
-- 	
Oracle
Dr Paul Dale | Cryptographer | Network Security & Encryption 
Phone +61 7 3031 7217
Oracle Australia



More information about the openssl-project mailing list