[openssl-project] crypto/bn/asm/x86/ gone, but still used by crypto/bn/asm/x86.pl?

Viktor Dukhovni openssl-users at dukhovni.org
Tue Feb 6 15:55:49 UTC 2018


In master and OpenSSL_1_1_0-stable we have:

commit df8c39d52256c2e5327a636928b6d1ed05f695a2
Author: Rich Salz <rsalz at openssl.org>
Date:   Tue Sep 30 17:30:19 2014 -0400

    RT3549: Remove obsolete files in crypto
    
    Reviewed-by: Andy Polyakov <appro at openssl.org>

 crypto/bn/asm/x86/add.pl     |  76 ------
 crypto/bn/asm/x86/comba.pl   | 277 --------------------
 crypto/bn/asm/x86/div.pl     |  15 --
 crypto/bn/asm/x86/f          |   3 -
 crypto/bn/asm/x86/mul.pl     |  77 ------
 crypto/bn/asm/x86/mul_add.pl |  87 -------
 crypto/bn/asm/x86/sqr.pl     |  60 -----
 crypto/bn/asm/x86/sub.pl     |  76 ------
 36 files changed, 5815 deletions(-)

All the crypto/bn/asm/x86/*.pl are deleted, but they are still
required by:

$ head -n18 crypto/bn/asm/x86.pl 
#! /usr/bin/env perl
# ... copyright ...

push(@INC,"perlasm","../../perlasm");
require "x86asm.pl";

require("x86/mul_add.pl");
require("x86/mul.pl");
require("x86/sqr.pl");
require("x86/div.pl");
require("x86/add.pl");
require("x86/sub.pl");
require("x86/comba.pl");

Is that file obsolete also?  Is there no need for asm support for "bn"
on x86?

-- 
	Viktor.



More information about the openssl-project mailing list