[openssl-project] Fwd: [openssl-commits] Broken: openssl/openssl#15866 (master - cf8e923)

[Richard Levitte]

I think I said it earlier, that prefixing the output with '#' is a TAP
compatible way to fix this.  One way is to pipe the execution of the
program through a "sed -e 's|^|# |'", except that it's not exactly
portable...  Another way *might* be to open("program |") and handle
the output in OpenSSL::Test.  However, both these solutions will mess
with all the test programs that we've made TAP friendly.

Hmmmm...

Come to think of it, a third option is to have the openssl program
notice the environment variable 'OPENSSL_HARNESS_PREFIX' that contains
a string to prefix all the output with, and in that case, use a custom
BIO filter that gets pushed on bio_out.

Actually, I think that last idea is the one to go for.

Cheers,
Richard

In message <f60c8f89-44b5-48c2-7bcb-caba725520e3 at openssl.org> on Fri, 26 Jan 2018 16:32:10 +0000, Matt Caswell <matt at openssl.org> said:

matt> This looks like another instance of this:
matt> 
matt> https://mta.openssl.org/pipermail/openssl-project/2018-January/000140.html
matt> 
matt> i.e. the word "ok" appearing at the beginning of a line in test_store
matt> while it is printing base-64 encoded output - which then confuses TAP
matt> 
matt> Richard - any ideas?
matt> 
matt> Matt
matt> 
matt> 
matt> -------- Forwarded Message --------
matt> Subject: 	[openssl-commits] Broken: openssl/openssl#15866 (master - cf8e923)
matt> Date: 	Fri, 26 Jan 2018 16:10:35 +0000
matt> From: 	Travis CI <builds at travis-ci.org>
matt> To: 	openssl-commits at openssl.org
matt> 
matt> 
matt> 
matt> *openssl / openssl
matt> <https://travis-ci.org/openssl/openssl?utm_source=email&utm_medium=notification>*
matt> (master <https://github.com/openssl/openssl/tree/master>)
matt> 
matt> 	Build #15866 was broken.
matt> <https://travis-ci.org/openssl/openssl/builds/333780174?utm_source=email&utm_medium=notification>
matt> 	
matt> 28 minutes and 51 seconds
matt> 	*Benjamin Kaduk* 	cf8e923
matt> <https://github.com/openssl/openssl/commit/cf8e9233f0139f8ebacbfd4fa34ccf410ec8430c>
matt> Changeset →
matt> <https://github.com/openssl/openssl/compare/c1acef9263b8...cf8e9233f013>
matt>   	Catch some more old sigalg names in comments
matt> 
matt> Make the sigalg name in comments reflect one that actually exists
matt> in the draft standard.
matt> 
matt> Reviewed-by: Matt Caswell <matt at openssl.org>
matt> (Merged from https://github.com/openssl/openssl/pull/5174)
matt> 
matt> *Want to know about upcoming build environment updates?*
matt> 
matt> Would you like to stay up-to-date with the upcoming Travis CI build
matt> environment updates? We set up a mailing list for you! Sign up here
matt> <http://eepurl.com/9OCsP>.
matt> 
matt> 	Documentation <https://docs.travis-ci.com> about Travis CI
matt> Need help? Mail support <mailto:support at travis-ci.com>!
matt> Choose who receives these build notification emails in your
matt> configuration file <https://docs.travis-ci.com/user/notifications>.
matt> 
matt> *Would you like to test your private code?*
matt> 
matt> Travis CI for Private Projects
matt> <https://travis-ci.com?utm_source=build_email_footer&utm_campaign=travis-ci.org&utm_medium=email>
matt> could be your new best friend!
matt>