Flaw in our process for dealing with trivial changes
Dr Paul Dale
paul.dale at oracle.com
Thu Dec 12 21:31:10 UTC 2019
A red blocker along the lines of: “Triviality Unconfirmed”. One of the reviewers needs to remove this before the PR can be merged.
It’s in our face, it prevent accidental merges and its low overhead.
Dr Paul Dale | Distinguished Architect | Cryptographic Foundations
Phone +61 7 3031 7217
> On 13 Dec 2019, at 7:06 am, Dr Paul Dale <paul.dale at oracle.com> wrote:
> Before we start over engineering a solution, how about we try just having an automatic visual indicator for trivial PRs.
> Dr Paul Dale | Distinguished Architect | Cryptographic Foundations
> Phone +61 7 3031 7217
> Oracle Australia
>> On 13 Dec 2019, at 3:24 am, Kurt Roeckx <kurt at roeckx.be <mailto:kurt at roeckx.be>> wrote:
>> On Thu, Dec 12, 2019 at 12:10:35PM +0000, Matt Caswell wrote:
>>> But in principle I agree that addrev could be used to do this. It's not
>>> quite as robust as doing it in the commit hook - because you don't
>>> *have* to use addrev. But, AFAIK, everyone does - so that's probably
>>> good enough.
>> I have never used addrev.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the openssl-project