[openssl-project] inline functions

Kurt Roeckx kurt at roeckx.be
Sun Jan 27 10:53:46 UTC 2019


On Sun, Jan 27, 2019 at 08:33:06PM +1000, Tim Hudson wrote:
> From https://github.com/openssl/openssl/pull/7721
> 
> Tim - I think inline functions in public header files simply shouldn't be
> present.
> Matt - I agree
> Richard - I'm ambivalent... in the case of stack and lhash, the generated
> functions we made static inline expressly to get better C type safety, and
> to get away from the mkstack.pl horror.

In general I have to agree that it's not a good thing to do,
specially in cases where it calls other functions. We went away
from making them just defines into functions, but they should
instead be functions in the library, at least for external users
of the library.


Kurt



More information about the openssl-project mailing list