No two reviewers from same company
Matt Caswell
matt at openssl.org
Thu May 23 17:20:11 UTC 2019
On 23/05/2019 18:14, Tomas Mraz wrote:
> On Thu, 2019-05-23 at 17:17 +0200, Richard Levitte wrote:
>> On Thu, 23 May 2019 16:25:07 +0200,
>> Salz, Rich wrote:
>>> I understand that OpenSSL is changing things so that, by mechanism
>>> (and maybe by policy although
>>> it’s not published yet), two members of the same company cannot
>>> approve the same PR. That’s
>>> great. (I never approved Akamai requests unless it was trivial
>>> back when I was on the OMC.)
>>
>> We mostly seem to agree that it's morally dubious to approve stuff
>> from people of the same company, and as far as I've heard so far,
>> it's
>> to ensure that the project's interests are over-ridden by company
>> interests (including involuntary bias, which no one is really free
>> from).
>
> Does this also apply to non-committers submitting a PR being the same
> company as one of the two required reviewers?
IMO: no it should not apply.
Matt
More information about the openssl-project
mailing list