BIO_do_accept Issue

[Viktor Dukhovni]

On Thu, Apr 09, 2020 at 11:42:11AM +0100, Scott Morgan via openssl-users wrote:

> > It seems to me that since commit 417be660e1c BIO_do_accept() has
> > incomplete error handling, "ret" isn't assigned when bind() or listen()
> > fail:
> > 
> ...<snip>...
> > 
> > So the function returns the wrong value of ret, in your case the the
> > socket descriptor created in an earlier case in the loop.  The fix is
> > presumably to set ret to either -1 or 0, whichever is appropriate here.
> > 
> 
> That makes sense. Just checked github, and there is a ticket listing
> that problem, #7717

Thanks for finding that, and posting the PR.  The fix will surely be
included when 1.1.1g is released.

-- 
    Viktor.