[openssl] master update

Richard Levitte levitte at openssl.org
Fri Feb 5 15:54:17 UTC 2021


The branch master has been updated
       via  2bb05a9668323ac2719f84cf8e9ccffc2bc99916 (commit)
      from  5682e77dff5123f0e9259c258bb58bc6d2e358ef (commit)


- Log -----------------------------------------------------------------
commit 2bb05a9668323ac2719f84cf8e9ccffc2bc99916
Author: Richard Levitte <levitte at openssl.org>
Date:   Sun Jan 31 23:15:08 2021 +0100

    PROV: Fix encoding of MDWithRSAEncryption signature AlgorithmID
    
    All {MD}WithRSAEncryption signature AlgorithmID have the parameters
    being NULL, according to PKCS#1.  We didn't.  Now corrected.
    
    This bug was the topic of this thread on openssl-users at openssl.org:
    https://mta.openssl.org/pipermail/openssl-users/2021-January/013416.html
    
    Reviewed-by: Tomas Mraz <tomas at openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/14030)

-----------------------------------------------------------------------

Summary of changes:
 providers/common/der/der_rsa_sig.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/providers/common/der/der_rsa_sig.c b/providers/common/der/der_rsa_sig.c
index 94ed60b69f..7fb69f87b0 100644
--- a/providers/common/der/der_rsa_sig.c
+++ b/providers/common/der/der_rsa_sig.c
@@ -58,7 +58,9 @@ int ossl_DER_w_algorithmIdentifier_MDWithRSAEncryption(WPACKET *pkt, int tag,
     }
 
     return ossl_DER_w_begin_sequence(pkt, tag)
-        /* No parameters (yet?) */
+        /* PARAMETERS, always NULL according to current standards */
+        && ossl_DER_w_null(pkt, -1)
+        /* OID */
         && ossl_DER_w_precompiled(pkt, -1, precompiled, precompiled_sz)
         && ossl_DER_w_end_sequence(pkt, tag);
 }


More information about the openssl-commits mailing list