[openssl/openssl] 4bcbf8: Coverity 1531872: j is not used anywhere later, re...

[Tomáš Mráz]

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 4bcbf8d4445e763857563d9ca016972e095c622d
      https://github.com/openssl/openssl/commit/4bcbf8d4445e763857563d9ca016972e095c622d
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/x509/by_dir.c

  Log Message:
  -----------
  Coverity 1531872: j is not used anywhere later, remove the assignment


  Commit: 7efc073dd7ddaed732c35e84efc865463db7ffbc
      https://github.com/openssl/openssl/commit/7efc073dd7ddaed732c35e84efc865463db7ffbc
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M providers/implementations/rands/drbg.c

  Log Message:
  -----------
  Coverity 1531836: Check return value of CRYPTO_atomic_add()


  Commit: a3fcafb34994c4864d8dc92a88f9d8e354230d12
      https://github.com/openssl/openssl/commit/a3fcafb34994c4864d8dc92a88f9d8e354230d12
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M test/x509_check_cert_pkey_test.c

  Log Message:
  -----------
  Coverity 1529992: Check return value of sscanf()

Also moving the call to setup_tests() where it
fits better.


  Commit: 0c6c3782870663dd190009103f22263f9a99c82e
      https://github.com/openssl/openssl/commit/0c6c3782870663dd190009103f22263f9a99c82e
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/asn1/i2d_evp.c

  Log Message:
  -----------
  Coverity 1528496: remove assignment of unused value

ctx is used only within the loop and always assigned at start


  Commit: f9a4e2b663ab97de718e016b29644d0c2bd9b7c3
      https://github.com/openssl/openssl/commit/f9a4e2b663ab97de718e016b29644d0c2bd9b7c3
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/bn/bn_exp.c

  Log Message:
  -----------
  Coverity 1528494 and 1528493: Remove unused assignment of wvalue

wvalue is always initialized at the beginning of each cycle
and used only within the cycle


  Commit: a33842efa51ca3f021310e10f444afef1e779fee
      https://github.com/openssl/openssl/commit/a33842efa51ca3f021310e10f444afef1e779fee
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/asn1/a_time.c

  Log Message:
  -----------
  Coverity 1528492: Fix possible memory leak if t == NULL


  Commit: 82b81161de41fde034f0d19e2ccddf190e4d8baf
      https://github.com/openssl/openssl/commit/82b81161de41fde034f0d19e2ccddf190e4d8baf
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M apps/s_server.c

  Log Message:
  -----------
  Coverity 1528490: Avoid assignment of unused value of i

It is used only within the loop and initialized at the beginning


  Commit: c71b72acf24f1a3b4d9d07fe552fe1d5f76a2e35
      https://github.com/openssl/openssl/commit/c71b72acf24f1a3b4d9d07fe552fe1d5f76a2e35
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/http/http_client.c

  Log Message:
  -----------
  Coverity 1528488: Avoid assignment of unused value rctx

Also some move redirection_url inside loop
where it is only used.


  Commit: 265920f2a78ff295264824b5d8294dd45173ae42
      https://github.com/openssl/openssl/commit/265920f2a78ff295264824b5d8294dd45173ae42
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/txt_db/txt_db.c

  Log Message:
  -----------
  Coverity 1528487: Avoid assignment of unused value of i


  Commit: ef1ed411e1d526cdf6b87613d1b6021ab07d0f2e
      https://github.com/openssl/openssl/commit/ef1ed411e1d526cdf6b87613d1b6021ab07d0f2e
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M apps/pkcs12.c

  Log Message:
  -----------
  Coverity 1528486: Avoid assignment of unused value of bags

It is used only within the loop and always initialized


  Commit: ade969e27b71a57e4d44ebada093929cc8f4193c
      https://github.com/openssl/openssl/commit/ade969e27b71a57e4d44ebada093929cc8f4193c
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2023-06-10 (Sat, 10 Jun 2023)

  Changed paths:
    M crypto/bn/bn_exp.c

  Log Message:
  -----------
  Coverity 1528485: Remove unused assignment of wvalue

wvalue is always initialized at the beginning of each cycle
and used only within the cycle

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/21145)


Compare: https://github.com/openssl/openssl/compare/c4ce0e3303d5...ade969e27b71