[openssl/openssl] fcf3a9: tls1_set_groups_list: freeing *pext before overwri...
David von Oheimb
noreply at github.com
Sat Mar 25 08:34:25 UTC 2023
Branch: refs/heads/openssl-3.0
Home: https://github.com/openssl/openssl
Commit: fcf3a9f7c6a10acb2d92f03aec5e45df7dd712d5
https://github.com/openssl/openssl/commit/fcf3a9f7c6a10acb2d92f03aec5e45df7dd712d5
Author: Peter Kaestle <peter.kaestle at nokia.com>
Date: 2023-03-24 (Fri, 24 Mar 2023)
Changed paths:
M ssl/t1_lib.c
Log Message:
-----------
tls1_set_groups_list: freeing *pext before overwriting
calling SSL_CTX_set1_groups_list() twice on one SSL_CTX* caused a memory
leak visible in valgrind:
4 bytes in 1 blocks are definitely lost in loss record 1 of 1
at 0x4841888: malloc (vg_replace_malloc.c:381)
by 0x4B1EE96: CRYPTO_memdup (in libcrypto.so.3)
by 0x48993A0: tls1_set_groups_list (in libssl.so.3)
by 0x487AA7E: ssl3_ctx_ctrl (in libssl.so.3)
by 0x1091EA: main (mem_leak.c:10)
LEAK SUMMARY:
definitely lost: 4 bytes in 1 blocks
Freeing *pext to fix it.
CLA: trivial
Signed-off-by: Peter Kaestle <peter.kaestle at nokia.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Richard Levitte <levitte at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20317)
Commit: d5e50bdf87053d99e8fce50ac57d94bbed571b56
https://github.com/openssl/openssl/commit/d5e50bdf87053d99e8fce50ac57d94bbed571b56
Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
Date: 2023-03-25 (Sat, 25 Mar 2023)
Changed paths:
M apps/cmp.c
M doc/man1/openssl-cmp.pod.in
M doc/man3/OSSL_CMP_CTX_new.pod
Log Message:
-----------
CMP app and doc: improve texts on (un-)trusted certs, srvCert, etc.
Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/20277)
Compare: https://github.com/openssl/openssl/compare/20a874ec4ae2...d5e50bdf8705
More information about the openssl-commits
mailing list