[openssl/openssl] 62ea5f: tls1_set_groups_list: freeing *pext before overwri...
openssl-machine
noreply at github.com
Sat Mar 25 08:34:25 UTC 2023
Branch: refs/heads/master
Home: https://github.com/openssl/openssl
Commit: 62ea5ffa7c8882ba90b26ab1deb0d977dcb5165c
https://github.com/openssl/openssl/commit/62ea5ffa7c8882ba90b26ab1deb0d977dcb5165c
Author: Peter Kaestle <peter.kaestle at nokia.com>
Date: 2023-03-24 (Fri, 24 Mar 2023)
Changed paths:
M ssl/t1_lib.c
Log Message:
-----------
tls1_set_groups_list: freeing *pext before overwriting
calling SSL_CTX_set1_groups_list() twice on one SSL_CTX* caused a memory
leak visible in valgrind:
4 bytes in 1 blocks are definitely lost in loss record 1 of 1
at 0x4841888: malloc (vg_replace_malloc.c:381)
by 0x4B1EE96: CRYPTO_memdup (in libcrypto.so.3)
by 0x48993A0: tls1_set_groups_list (in libssl.so.3)
by 0x487AA7E: ssl3_ctx_ctrl (in libssl.so.3)
by 0x1091EA: main (mem_leak.c:10)
LEAK SUMMARY:
definitely lost: 4 bytes in 1 blocks
Freeing *pext to fix it.
CLA: trivial
Signed-off-by: Peter Kaestle <peter.kaestle at nokia.com>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Richard Levitte <levitte at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20317)
(cherry picked from commit fcf3a9f7c6a10acb2d92f03aec5e45df7dd712d5)
More information about the openssl-commits
mailing list