[openssl/openssl] 98d601: Make OPENSSL_sk_push return only 0 or 1

Tomáš Mráz noreply at github.com
Thu Jan 4 13:53:48 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 98d6016afec4c0bc7bb8f33b5061beb8528cc74a
      https://github.com/openssl/openssl/commit/98d6016afec4c0bc7bb8f33b5061beb8528cc74a
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2024-01-04 (Thu, 04 Jan 2024)

  Changed paths:
    M CHANGES.md
    M crypto/stack/stack.c
    M doc/man3/DEFINE_STACK_OF.pod

  Log Message:
  -----------
  Make OPENSSL_sk_push return only 0 or 1

Most of the callers do not actually check for
the special -1 return condition because they do not
pass NULL to it. It is also extremely improbable that
any code depends on this -1 return value in this condition
so it can be safely changed to 0 return.

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Ben Kaduk <kaduk at mit.edu>
(Merged from https://github.com/openssl/openssl/pull/22930)




More information about the openssl-commits mailing list