[openssl-project] build/test before merging
Dr. Matthias St. Pierre
Matthias.St.Pierre at ncp-e.com
Thu May 24 20:32:38 UTC 2018
There is also the custom to add something like "(to be squashed)" or "(fixup)" in round or square brackets to the end oft he commit title. So maybe also add a regex for "squash" or "fixup" inside round or square brackets?
Von: openssl-project <openssl-project-bounces at openssl.org> Im Auftrag von Richard Levitte
Gesendet: Mittwoch, 23. Mai 2018 18:02
An: openssl-project at openssl.org
Betreff: Re: [openssl-project] build/test before merging
In message <6d5b206f-a0f1-8b60-fbf5-5f08c7c269d7 at openssl.org> on Wed, 23 May 2018 16:54:23 +0100, Matt Caswell <matt at openssl.org> said:
matt> On 23/05/18 16:50, Benjamin Kaduk wrote:
matt> > But I am curious if we currently do and/or should have a commit
matt> > hook on git.openssl.org to reject commits that start with "!fixup".
That's "fixup! ", and "squash! " (for --squash) should be added as well.
matt> Not that I know of. We probably should have. A quick check reveals
matt> two such commits that have made it into master...both mine
matt> unfortunately :-(
I've been close a couple of times...
But yeah, good idea, I'll go ahead and craft that together. Gitolite makes it quite easy to configure.
Richard Levitte levitte at openssl.org
OpenSSL Project http://www.openssl.org/~levitte/
openssl-project mailing list
openssl-project at openssl.org
More information about the openssl-project